Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #50 , Compatible with VS 2017 #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed issue #50 , Compatible with VS 2017 #52

wants to merge 2 commits into from

Conversation

Dilip-Nandakumar
Copy link

Upgrade the project to be compatible with VS 2017 and latest .net framework version 4.7.1 and .net core version 2.0 and .net standard version 2.0.

Upgrade the project to be compatible with VS 2017 and latest .net framework version 4.7.1 and .net core 2.0.
@Dilip-Nandakumar
Copy link
Author

I am a first time to open source contribution.

Kindly guide me and let me know if any additional changes are to be done.

@vidstige
Copy link
Owner

vidstige commented Mar 8, 2018

Hi,
I totally missed this. Thanks for helping out.

I see that the build is red, will look into that and see how we can proceed.

@vidstige
Copy link
Owner

vidstige commented Mar 8, 2018

There are new filenames, etc for the project files. To be able to run from command line (so that the library can be verified automatically, it needs to be able to build from command line). Right now this is done via the build.cmd file. Open this to learn more. You will need to update the build.cmd. I think we need something like msbuild.exe" NRasterizer.sln /p:Configuration=Release

@vidstige
Copy link
Owner

vidstige commented Mar 8, 2018

Please try out locally first so that you can build from command line locally, then it's very likely it will work on the build server as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants