Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo.js: Cannot read property 'getJSON' of undefined #74

Closed
MatthewHallCom opened this issue Mar 22, 2016 · 8 comments
Closed

Vimeo.js: Cannot read property 'getJSON' of undefined #74

MatthewHallCom opened this issue Mar 22, 2016 · 8 comments

Comments

@MatthewHallCom
Copy link

Getting this error when trying to use a Vimeo embed
Vimeo.js:94 Uncaught TypeError: Cannot read property 'getJSON' of undefined

Code is embedded like this
<div data-setup="{ "techOrder": ["vimeo"], "sources": [{ "type": "video/vimeo", "src": "https://vimeo.com/153836040"}] }" class="video-js vjs-sublime-skin vjs-paused project-video-dimensions" id="project-video"></div>

Here are my versions.
"videojs-vimeo": "^2.0.0",
"video.js": "videojs#^5.8.5",

@IJsLauw
Copy link

IJsLauw commented Apr 18, 2016

Same problem here... seams the url has changed or is different for hidden video's?

@gor181
Copy link

gor181 commented Apr 28, 2016

It depends on global jQuery...
http://prntscr.com/axsl57

Adding jQuery as global dep will solve this.
It should support jQuery as module as it's doing now for video.js

@janxalot
Copy link

I have jQuery added as a global dependency for a project I am working on and I am still encountering this error message.

The default video.js package works fine, just trying to use the vimeo add-on returns the error.

Any ideas?

@joelstransky
Copy link

This is a big issue when using no-conflict jquery.
You should probably use a non-jquery ajax request. http://youmightnotneedjquery.com/#request
In the mean time, anyone have an idea how to fix this?

@hiraylo
Copy link

hiraylo commented Oct 10, 2016

A quick fix would be to replace the $ with jQuery so that it reads like jQuery.getJSON

@joelstransky
Copy link

That's an edit to source which makes upgrading impossible. The authors
should just fix it.

On Sun, Oct 9, 2016, 7:05 PM hiraylo [email protected] wrote:

A quick fix would be to replace the $with jQuery so that it reads like
jQuery.getJSON


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#74 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMPGETPez4vw0-XbP_VNgFTGWsD2QEzks5qyceYgaJpZM4H2k0H
.

@janxalot
Copy link

Agree 100%!

@gkatsev
Copy link
Member

gkatsev commented May 11, 2017

Should be fixed in master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants