fix: mark global as global via externalGlobals #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the built-in globals feature will try and do interop resolution for requiring `window` which will break if a user has an element with an id of `default`. This plugin does not do so and will end up removing the lines from the browser build altogether.
| @@ -92,6 +90,7 @@ const ORDERED_DEFAULTS = { | |||
| 'resolve', | |||
| 'json', | |||
| 'commonjs', | |||
| 'externalGlobals', | |||
There was a problem hiding this comment.
Seems like we should be adding this plugin to the browser dist only. The module dist should keep the require/import.
There was a problem hiding this comment.
Yup, it's only getting added here, for the browser builds.
There was a problem hiding this comment.
ahh your right, the way that github showed the diff let me to believe it was under module.
brandonocasey
approved these changes
Aug 31, 2021
gkatsev
added a commit
to videojs/video.js
that referenced
this pull request
Sep 21, 2021
built off of the work in videojs/videojs-generate-rollup-config#40
gkatsev
added a commit
to videojs/vhs-utils
that referenced
this pull request
Sep 21, 2021
gkatsev
added a commit
to videojs/mpd-parser
that referenced
this pull request
Sep 21, 2021
gkatsev
added a commit
to videojs/http-streaming
that referenced
this pull request
Sep 21, 2021
2 tasks
gkatsev
added a commit
to videojs/vhs-utils
that referenced
this pull request
Sep 22, 2021
gkatsev
added a commit
to videojs/mpd-parser
that referenced
this pull request
Sep 22, 2021
gkatsev
added a commit
to videojs/video.js
that referenced
this pull request
Sep 22, 2021
built off of the work in videojs/videojs-generate-rollup-config#40
gkatsev
added a commit
to videojs/http-streaming
that referenced
this pull request
Sep 22, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the built-in globals feature will try and do interop resolution
for requiring
windowwhich will break if a user has an element with anid of
default. This plugin does not do so and will end up removing thelines from the browser build altogether.