This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Live playlist loading improvements #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,6 +94,7 @@ | |||
|
|
|||
| // refresh live playlists after a target duration passes | |||
| if (!loader.media().endList) { | |||
| window.clearTimeout(mediaUpdateTimeout); | |||
There was a problem hiding this comment.
This had to be a huge pain to track down. Thank you!
|
Updated PR according to your comments. |
| @@ -1035,7 +1035,7 @@ videojs.Hls.translateMediaIndex = function(mediaIndex, original, update) { | |||
| // bitrate switches should be happening here. | |||
| translatedMediaIndex = (mediaIndex + (original.mediaSequence - update.mediaSequence)); | |||
|
|
|||
| if (translatedMediaIndex >= update.segments.length || translatedMediaIndex < 0) { | |||
| if (translatedMediaIndex > update.segments.length || translatedMediaIndex < 0) { | |||
There was a problem hiding this comment.
This change doesn't feel right. Segments is a 0-indexed array, so update.segments.length is an out-of-bounds element. Why is this necessary?
There was a problem hiding this comment.
When all the segments currently available in a live playlist have been downloaded, mediaIndex will point to one beyond the end. There's nothing wrong with this situation, we're just waiting for a playlist refresh. It's incorrect to reset mediaIndex back to the live point if this occurs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We managed to fix the problems described in #236. This PR consists of two commits.
The repetition of chunks was caused because media index didn't need to be translated when changing quality. The playlist was the same and translation should not occur.
The second commit fixes crazy loading of playlists and chunks after several quality changes as timeouts accumulated and produced more and more requests.