Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

add entry of require() for webpack #1307

Closed
wants to merge 1 commit into from

Conversation

hexray-newbee
Copy link

@hexray-newbee hexray-newbee commented Dec 14, 2017

Description

fix #600

Specific Changes proposed

add entry of require() for webpack

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Dec 14, 2017

I'm not sure this will actually fix it. Not sure about webpack, but browserify doesn't like importing browserified code unless it ran through derequire, so, that could be an issue.
Though, I think the main issue is that webpack users would still need to configure this because our UMD build expects videojs to be available globally: https://github.com/videojs/videojs-contrib-hls/blob/master/package.json#L63-L67

@thecotne
Copy link

@gkatsev

our UMD build expects videojs to be available globally

why is that?

wouldn't UMD package use require/define function to import dependencies ?

and use global variables if require and define are not available

and list dependencies as peerDependencies

like this https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js

@forbesjo
Copy link
Contributor

#600 is fixed, closing

@forbesjo forbesjo closed this Aug 13, 2018
@hexray-newbee hexray-newbee deleted the patch-1 branch August 13, 2018 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for webpack?
4 participants