Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoJS wants Sources, DashJS wants NO Sources #91

Closed
richardbushell opened this issue Jul 12, 2016 · 3 comments
Closed

VideoJS wants Sources, DashJS wants NO Sources #91

richardbushell opened this issue Jul 12, 2016 · 3 comments

Comments

@richardbushell
Copy link

We have an issue with the loadstart event firing twice.
VideoJS wants expressly stated Sources within the Video tag, DashJS wants NO Sources and wants to add the Source programmatically.
Bottom line is that double loadstart events are triggered, meaning that VJS 5.10.2+ fails.
See:
videojs/video.js#3428
Could videojs-contrib-dash make them play together nicely? Or should VideoJS add programmatic source option?
Any ideas please?
@forbesjo
Copy link
Contributor

We can investigate and see if there's a way to disable this behavior in dashjs. If possible you can leave the video element without source elements and change the source with player.src({src: ..., type: ...}) (see https://github.com/videojs/videojs-contrib-dash/blob/master/example.html#L42) as a workaround.

@richardbushell
Copy link
Author

richardbushell commented Jul 20, 2016 •
edited
Loading

Thanks, will try programmatically adding the source. In the meantime, I did pinpoint the break point. (from VJS issue post):
VJS 5.9.2 is OK. VJS 5.10.1 breaks.
Culprit is definitely VJS: videojs/video.js#3285
Result is that some browsers now no longer select and play the dash source and now revert to fallback mp4 playback. Chrome & Edge still play dash, BUT Firefox and IE now revert to MP4 fallback.

@richardbushell
Copy link
Author

Thanks Jo, yes programmatic sources solved the problem. Currently I believe that anyone using html source tags will now break dash handling if using VJS 5.10.1+ due to: videojs/video.js#3285
I will close this here as it is best fixed through a VJS issue, not contrib.

forbesjo pushed a commit that referenced this issue Jul 25, 2016
Update README example
d4cd740 
Update the README example to demonstrate setting the player source
programmatically. Issue #91 indicates that dashjs will automatically
create a mediaPlayer if there is a dash source present in the media
element. If the mediaPlayer is already created then video.js will fire
two `loadstart` events.
forbesjo added a commit that referenced this issue Aug 2, 2016
@forbesjo
Clean up the build process (#92)
d99d68a 
* Move babelified file

Remove babelify from the build process

* Build to es5 folder

* Add build to npm scripts

* Clean up example page

* Update README example

Update the README example to demonstrate setting the player source
programmatically. Issue #91 indicates that dashjs will automatically
create a mediaPlayer if there is a dash source present in the media
element. If the mediaPlayer is already created then video.js will fire
two `loadstart` events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forbesjo @richardbushell