Code

Ad state refactor#315

Code

Merged

incompl merged 51 commits intomastervideojs/videojs-contrib-ads:masterfrom ad-state-refactorvideojs/videojs-contrib-ads:ad-state-refactorCopy head branch name to clipboardFeb 23, 2018

+2,087-1,054

Commits

Commits on Feb 21, 2018

• first

  

  Greg Smith

  committed
  c4f92b2

  Copy full SHA for c4f92b2

• lint

  

  Greg Smith

  committed
  ffeb62a

  Copy full SHA for ffeb62a

• test stuff

  

  Greg Smith

  committed
  a248e63

  Copy full SHA for a248e63

• fix tests

  

  Greg Smith

  committed
  a65fbe8

  Copy full SHA for a65fbe8

• finish first pass at BeforePreroll.js

  

  Greg Smith

  committed
  e3432a0

  Copy full SHA for e3432a0

• wip

  

  Greg Smith

  committed
  a721c03

  Copy full SHA for a721c03

• fix "this" bugs in endlinearadmode

  

  Greg Smith

  committed
  a3271a4

  Copy full SHA for a3271a4

• wip

  

  Greg Smith

  committed
  6e0141d

  Copy full SHA for 6e0141d

• get rollup and imports worked out

  

  Greg Smith

  committed
  c4ed56e

  Copy full SHA for c4ed56e

• progress

  

  Greg Smith

  committed
  b436b17

  Copy full SHA for b436b17

• fix ended event w/ no postroll

  

  Greg Smith

  committed
  14bbec4

  Copy full SHA for 14bbec4

• cleanup

  

  Greg Smith

  committed
  e1bcaa0

  Copy full SHA for e1bcaa0

• finishing up postroll refactor

  

  Greg Smith

  committed
  b00ceeb

  Copy full SHA for b00ceeb

• fix some tests

  

  Greg Smith

  committed
  6b54458

  Copy full SHA for 6b54458

• updating more tests

  

  Greg Smith

  committed
  6fe4ac9

  Copy full SHA for 6fe4ac9

• tests pass!

  

  Greg Smith

  committed
  9d2627c

  Copy full SHA for 9d2627c

• wip removing state machine

  

  Greg Smith

  committed
  4f75618

  Copy full SHA for 4f75618

• tests passing without state machine!

  

  Greg Smith

  committed
  38d31eb

  Copy full SHA for 38d31eb

• progress

  

  Greg Smith

  committed
  3e4b7db

  Copy full SHA for 3e4b7db

• progress

  

  Greg Smith

  committed
  d82c9ca

  Copy full SHA for d82c9ca

• nopreroll working

  

  Greg Smith

  committed
  2aa4184

  Copy full SHA for 2aa4184

• fix case in path

  

  Greg Smith

  committed
  ea3058b

  Copy full SHA for ea3058b

• progress

  

  Greg Smith

  committed
  3240014

  Copy full SHA for 3240014

• Some cleanup / renaming

  

  Greg Smith

  committed
  1235a37

  Copy full SHA for 1235a37

• new test and nopreroll fix

  

  Greg Smith

  committed
  bc61034

  Copy full SHA for bc61034

• support transitionTo within ctor

  

  Greg Smith

  committed
  f462617

  Copy full SHA for f462617

• more tidiness

  

  Greg Smith

  committed
  f37decc

  Copy full SHA for f37decc

• roll back attempt to fix contentupdate beforepreroll, needs more thinking

  

  Greg Smith

  committed
  77c12fe

  Copy full SHA for 77c12fe

• tweaks, hopefully close to done for this pr

  

  Greg Smith

  committed
  ce2d2a3

  Copy full SHA for ce2d2a3

• fix bug with transitionTo

  

  Greg Smith

  committed
  a7dacce

  Copy full SHA for a7dacce

• further improve transitionTo

  

  Greg Smith

  committed
  af8aacd

  Copy full SHA for af8aacd

• lint

  

  Greg Smith

  committed
  3d17d46

  Copy full SHA for 3d17d46

• last things for this pr i promise maybe!

  

  Greg Smith

  committed
  d78d1e4

  Copy full SHA for d78d1e4

• finishing touches

  

  Greg Smith

  committed
  6725e42

  Copy full SHA for 6725e42

• contentchanged

  

  Greg Smith

  committed
  25d2669

  Copy full SHA for 25d2669

• code review changes

  

  Greg Smith

  committed
  9f4a745

  Copy full SHA for 9f4a745

• Code review updates / fixes

  

  Greg Smith

  committed
  48171b4

  Copy full SHA for 48171b4

• code review changes to tests

  

  Greg Smith

  committed
  3bf25bb

  Copy full SHA for 3bf25bb

• didnt mean to add this

  

  Greg Smith

  committed
  e884fb0

  Copy full SHA for e884fb0

• update readme and timeouts

  

  Greg Smith

  committed
  b79a936

  Copy full SHA for b79a936

• fix typo

  

  Greg Smith

  committed
  c6b749e

  Copy full SHA for c6b749e

• update migration guide

  

  Greg Smith

  committed
  d59171a

  Copy full SHA for d59171a

• update

  

  Greg Smith

  committed
  09d652f

  Copy full SHA for 09d652f

• readme code review changes

  

  Greg Smith

  committed
  086f176

  Copy full SHA for 086f176

• see if this fixes test timeouts

  

  Greg Smith

  committed
  50367c6

  Copy full SHA for 50367c6

• new state unit tests

  

  Greg Smith

  committed
  0a60617

  Copy full SHA for 0a60617

• try to prevent timeout by speeding up test

  

  Greg Smith

  committed
  73b18a9

  Copy full SHA for 73b18a9

• test code review changes

  

  Greg Smith

  committed
  e50d8fe

  Copy full SHA for e50d8fe

• Improve nopreroll handling in BeforePreroll

  

  Greg Smith

  committed
  5b6291c

  Copy full SHA for 5b6291c

Commits on Feb 22, 2018

• code review feedback

  

  Greg Smith

  committed
  360fe44

  Copy full SHA for 360fe44

• set contentResuming to true before ending midroll break

  

  Greg Smith

  committed
  1431c33

  Copy full SHA for 1431c33