Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoJS 5.0 Updates (DO NOT MERGE) #116

Closed
wants to merge 19 commits into from
Closed

VideoJS 5.0 Updates (DO NOT MERGE) #116

wants to merge 19 commits into from

Commits on Sep 28, 2015

  1. Use getComponent going forward

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    22c6b38 View commit details
    Browse the repository at this point in the history

  2. 'play' should be triggered on tech

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    8fea5b1 View commit details
    Browse the repository at this point in the history

  3. Add empty .npmignore

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    7266ad5 View commit details
    Browse the repository at this point in the history

  4. Simplify deferring behavior and refactor tests 

    - This removes the variable use of setImmediate/clearImmediate and RAF;
  replacing it with universal use of setTimeout.
- Tests were not great because they did a lot of manual overriding of
  setTimeout and friends. They will now use Sinon's fake timers feature
  instead.
- Updates tests to use QUnit 2.0 style, for future compatibility.
  Related to this, there is a general shift here away from relying on
  any global state (outside of helper functions) in tests as that
  makes them less atomic.
    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    c14f009 View commit details
    Browse the repository at this point in the history

  5. Use strict assertions

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    8371114 View commit details
    Browse the repository at this point in the history

  6. Update vjs and trigger on player instead of tech 

    Also added a `hasClass` function to make it easier to test that.
    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    c6b91f4 View commit details
    Browse the repository at this point in the history

  7. Fix async issue w/ test 

    Not sure why this one test needs async handling, but it appears to. The
only way to make it not async is to trigger the 'play' event on the
player's `tech_` object.
    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    71f8f0f View commit details
    Browse the repository at this point in the history

  8. Binding not necessary on these events

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    aea67a4 View commit details
    Browse the repository at this point in the history

  9. Re-evaluate tick amounts

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    d9be8fa View commit details
    Browse the repository at this point in the history

  10. Formatting/whitespace

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    5c6c381 View commit details
    Browse the repository at this point in the history

  11. Restore lost test

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    e074ca0 View commit details
    Browse the repository at this point in the history

  12. Flesh out timer-detection tests 

    This also renames the obscure `timeout` in the plugin to the more
meaningful `adTimeoutTimeout`.
    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    4425d5b View commit details
    Browse the repository at this point in the history

  13. Restore missing test

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    f9f349c View commit details
    Browse the repository at this point in the history

  14. Make test synchronous

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    bc2367b View commit details
    Browse the repository at this point in the history

  15. Bump video.js rc version

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    dd28ea0 View commit details
    Browse the repository at this point in the history

  16. Add 'main' to package.json

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    c5c975e View commit details
    Browse the repository at this point in the history

  17. Fix comment typo

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    c0e10f0 View commit details
    Browse the repository at this point in the history

  18. Bump to latest video.js rc

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    13b2bac View commit details
    Browse the repository at this point in the history

  19. Add migrating-to-3.0 doc

    @misteroneill
    misteroneill committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    38899d1 View commit details
    Browse the repository at this point in the history