Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable keyboard controls on menu items #8777

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: enable keyboard controls on menu items #8777

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56ff9a6
fix: enable keyboard controls on menu items
usmanonazim Jun 21, 2024
86a61ce
Merge branch 'main' into fix/keyboard-controls
usmanonazim Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/menu/menu-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
* @listens keydown
*/
handleKeyDown(event) {
if (['Tab', 'Escape', 'ArrowUp', 'ArrowLeft', 'ArrowRight', 'ArrowDown'].includes(event.key)) {
if (!['Tab', 'Escape', 'ArrowUp', 'ArrowLeft', 'ArrowRight', 'ArrowDown'].includes(event.key)) {

Check warning on line 97 in src/js/menu/menu-item.js

View check run for this annotation

Codecov / codecov/patch

src/js/menu/menu-item.js#L97 

Added line #L97 was not covered by tests
// Pass keydown handling up for unused keys
super.handleKeyDown(event);
}
Expand Down