Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace keycode dependency with event.key #8735
refactor: Replace keycode dependency with event.key #8735
Changes from 2 commits
b88755b
1059389
986a8bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 440 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L440
Check warning on line 444 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L444
Check warning on line 448 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L448
Check warning on line 456 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L456
Check warning on line 459 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L459
Check warning on line 466 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L466
Check warning on line 470 in src/js/control-bar/progress-control/seek-bar.js
Codecov / codecov/patch
src/js/control-bar/progress-control/seek-bar.js#L470
Check warning on line 142 in src/js/control-bar/volume-panel.js
Codecov / codecov/patch
src/js/control-bar/volume-panel.js#L142
Check warning on line 187 in src/js/control-bar/volume-panel.js
Codecov / codecov/patch
src/js/control-bar/volume-panel.js#L187
Check warning on line 300 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L300
Check warning on line 306 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L306
Check warning on line 312 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L312
Check warning on line 331 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L331
Check warning on line 359 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L359
Check warning on line 364 in src/js/menu/menu-button.js
Codecov / codecov/patch
src/js/menu/menu-button.js#L364
Check warning on line 97 in src/js/menu/menu-item.js
Codecov / codecov/patch
src/js/menu/menu-item.js#L97
This file was deleted.
Check warning on line 217 in src/js/menu/menu.js
Codecov / codecov/patch
src/js/menu/menu.js#L217
Check warning on line 223 in src/js/menu/menu.js
Codecov / codecov/patch
src/js/menu/menu.js#L223
Check warning on line 318 in src/js/slider/slider.js
Codecov / codecov/patch
src/js/slider/slider.js#L317-L318
Check warning on line 323 in src/js/slider/slider.js
Codecov / codecov/patch
src/js/slider/slider.js#L322-L323
Check warning on line 332 in src/js/slider/slider.js
Codecov / codecov/patch
src/js/slider/slider.js#L332
Check warning on line 338 in src/js/slider/slider.js
Codecov / codecov/patch
src/js/slider/slider.js#L338