Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure aria-labelledby values in track settings are valid #8711

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: Ensure aria-labelledby values in track settings are valid #8711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/js/tracks/text-track-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const selectConfigs = {

edgeStyle: {
selector: '.vjs-edge-style > select',
id: '%s',
id: '',
label: 'Text Edge Style',
options: [
['none', 'None'],
Expand All @@ -99,7 +99,7 @@ const selectConfigs = {

fontFamily: {
selector: '.vjs-font-family > select',
id: 'captions-font-family-%s',
id: '',
label: 'Font Family',
options: [
['proportionalSansSerif', 'Proportional Sans-Serif'],
Expand All @@ -114,7 +114,7 @@ const selectConfigs = {

fontPercent: {
selector: '.vjs-font-percent > select',
id: 'captions-font-size-%s',
id: '',
label: 'Font Size',
options: [
['0.50', '50%'],
Expand Down
18 changes: 18 additions & 0 deletions test/unit/tracks/text-track-select.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,21 @@ QUnit.test('should associate with <select>s with <options>s', function(assert) {
"select property 'aria-labelledby' is included in its option's property 'aria-labelledby'"
);
});

QUnit.test('aria-labelledby values must be valid and unique', function(assert) {
const player = TestHelpers.makePlayer({
tracks
});
const albs = player.$$('.vjs-text-track-settings select[aria-labelledby]');

albs.forEach(el => {
const ids = el.getAttribute('aria-labelledby').split(' ');
const invalidIds = ids.find(id => {
return !(player.$(`#${id}`));
});

assert.notOk(invalidIds, `${el.id} has valid aria-labelledby ids`);

assert.ok((new Set(ids)).size === ids.length, `${el.id} does not contain duplicate ids`);
});
});