Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add action to validate PR titles #8614

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Adds a GitHub action to validate that PR titles follow conventional commit, to make sure we don't merge a PR that wouldn't show up in the change log.

Specific Changes proposed

Adds a simple action to validate the title with a regex. There are GitHub marketplace actions which will do this, but they have a lot of dependencies and configuration options we don't need for now.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (6eb0230) to head (1deaa81).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8614   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7636     7636           
  Branches     1835     1835           
=======================================
  Hits         6316     6316           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have a question, though: why not introduce a tool like commitlint?

@mister-ben
Copy link
Contributor Author

mister-ben commented Mar 3, 2024

LGTM, I have a question, though: why not introduce a tool like commitlint?

That would enforce the format on each individual commit message, which isn't too important as we squash and merge, and wouldn't stop the PR title from being changed to something that doesn't fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants