Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement spatial navigation #8570

Merged
merged 155 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from 135 commits
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
bdb7e1c
feat(player): add spatialNavigation feature
bzizmo Nov 8, 2023
b2bb855
feat(player): add spatialNavigation class
CarlosVillasenor Nov 9, 2023
d7c4ba7
feat(player): update spatialNavigation class
CarlosVillasenor Nov 14, 2023
55130bb
feat(player): modify spatialNavigation class & modify component class
CarlosVillasenor Nov 24, 2023
750c72e
Added methods getPositions, handleFocus and handleBLur for spatial na…
bzizmo Nov 29, 2023
359e6cf
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Nov 29, 2023
e1e3a59
feat(player): modify Component class, BigPlayButton class & Clickable…
CarlosVillasenor Nov 29, 2023
60a2d5e
Added import in player.js, Created base methods inside spatial-naviga…
bzizmo Dec 1, 2023
b2f4c51
feat(player): modify Component class & SpatialNavigation class
CarlosVillasenor Dec 1, 2023
3a99013
feat(player): modify Component class
CarlosVillasenor Dec 5, 2023
7e180a8
added keydown event logic for spatial-navigation
bzizmo Dec 5, 2023
713ac98
fixed conflicts on spatial-navigation, removed unused import in compo…
bzizmo Dec 5, 2023
f96e649
feat(player): modify SpatialNavigation class
CarlosVillasenor Dec 5, 2023
f81bcfc
feat(player): modify SpatialNavigation class
CarlosVillasenor Dec 6, 2023
1232d27
feat(player): modify SpatialNavigation class
CarlosVillasenor Dec 6, 2023
241bf09
feat(player): modify SpatialNavigation class
CarlosVillasenor Dec 7, 2023
e2008da
feat(player): modify SpatialNavigation class
CarlosVillasenor Dec 12, 2023
6118b1c
Added logic for moving focus to the best candidate
bzizmo Dec 12, 2023
014d6eb
Implemented move, findBestCandidate, isInDirection, and calculateDist…
bzizmo Dec 18, 2023
1966c3e
Added a new player option enableKeydownListener, Added gap: 1px to co…
bzizmo Dec 20, 2023
2289953
feat(player): modify SpatialNavigation class & Component class
CarlosVillasenor Dec 20, 2023
5b8b08d
Removed enableKeydownListener flag, as user should start the SpatialN…
bzizmo Dec 21, 2023
e8e1dfd
Merge pull request #2 from bzizmo/spatial-navigation-blur-focus
bzizmo Dec 21, 2023
0745420
Added functionality to track changes in the focusableComponents list …
bzizmo Jan 5, 2024
c54953a
feat(player): modify SpatialNavigation class, ModalDialog & Componen…
CarlosVillasenor Jan 5, 2024
2bb76c3
Merge pull request #3 from bzizmo/fix/spatial-navigation-focus-lost
bzizmo Jan 8, 2024
00ac57f
feat(player): modify ModalDialog
CarlosVillasenor Jan 8, 2024
ad6ef57
Refactor SpatialNavigation to use player.spatialNavigation
bzizmo Jan 9, 2024
72b8d8b
Merge pull request #4 from bzizmo/refactor/spatial-navigation-scope
CarlosVillasenor Jan 9, 2024
a6208eb
Added a new custom event endOfFocusableComponents
bzizmo Jan 10, 2024
bc6ca03
Added new styles for focused elements in case spatial navigation is e…
bzizmo Jan 12, 2024
47612fc
feat(player): modify SpatialNavigation class:
CarlosVillasenor Jan 13, 2024
6ba35db
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Jan 13, 2024
ba994a4
Changed to window.SpatialNabigation to this.player_.spatialNavigation
bzizmo Jan 15, 2024
4011fb5
feat(player): modify text-track-settings, created test-track-settings…
CarlosVillasenor Jan 25, 2024
a96bf43
changed handleKeyDown inside component.js, getComponents method is no…
bzizmo Jan 25, 2024
ed074cc
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Jan 25, 2024
0202a36
Merge branch 'main' into spatial-navigation
bzizmo Jan 25, 2024
0827c84
feat(player): create TrackSettingsControls Component & Modify TextTra…
CarlosVillasenor Jan 26, 2024
498edc7
feat(player): Modify ModalDialog
CarlosVillasenor Jan 26, 2024
b701a95
getIsFocusable and getIsAvailableToBeFocused methods are now acceptin…
bzizmo Jan 29, 2024
b411f1f
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Jan 29, 2024
d7e8cf2
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Jan 29, 2024
4127413
feat(player): Modify TextTrackSettings:
CarlosVillasenor Jan 30, 2024
b5c047a
feat(player): Modify CaptionSettingsMenuItem:
CarlosVillasenor Jan 30, 2024
5ee3ba0
Merge branch 'videojs:main' into spatial-navigation
bzizmo Jan 30, 2024
96a5ee9
feat(player): Modify TextTrackSelect & TextTrackFieldset:
CarlosVillasenor Jan 31, 2024
25ec8dc
feat(player): Modify TrackSettingsControls:
CarlosVillasenor Jan 31, 2024
5399c35
feat(player): Modify SpatialNavigation, Component & ModalDialog:
CarlosVillasenor Feb 1, 2024
893e2d7
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Feb 1, 2024
7bc5a83
Merge pull request #5 from bzizmo/spatial-navigation-modal-as-component
bzizmo Feb 1, 2024
6868c87
Merge branch 'videojs:main' into spatial-navigation
bzizmo Feb 2, 2024
861d8e5
Handle ENTER keydown in Modals when spatial navigation is enabled
bzizmo Feb 2, 2024
f74156d
feat(player): Modify ModalDialog, spatialNavigation, TrackSettingsCon…
CarlosVillasenor Feb 3, 2024
f3eb1cf
Implement additional RCU controls
bzizmo Feb 6, 2024
31c7f1f
Merge pull request #7 from bzizmo/rcu-controls
bzizmo Feb 7, 2024
47b7e14
feat(player): Modify Component class:
CarlosVillasenor Feb 7, 2024
02e3411
feat(player): Modify ModalDialog & CaptionSettingsMenuItem
CarlosVillasenor Feb 8, 2024
4f4b83f
feat(player): Modify SpatialNavigation class:
CarlosVillasenor Feb 9, 2024
9b7cd97
feat(player): Modify SpatialNavigation class:
CarlosVillasenor Feb 9, 2024
3ee07c7
Update src/js/component.js
CarlosVillasenor Feb 15, 2024
45e5748
Update src/js/component.js
CarlosVillasenor Feb 15, 2024
8aba907
feat(player): Modify SpatialNavigation & Component class:
CarlosVillasenor Feb 15, 2024
67d9dd1
feat(player): Modify SpatialNavigation class:
CarlosVillasenor Feb 16, 2024
23c4533
feat(player): Modify SpatialNavigation class:
CarlosVillasenor Feb 16, 2024
08a51b9
Update src/js/spatial-navigation.js
CarlosVillasenor Feb 16, 2024
2479c27
feat(player): Modify ModalDialog class & MenuItem class:
CarlosVillasenor Feb 16, 2024
5538a20
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Feb 16, 2024
2d7df4a
removed unused property, remove this.focus, which was added for testi…
bzizmo Feb 19, 2024
1780f8a
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Feb 19, 2024
c8e02ad
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Feb 19, 2024
8d0701e
Changed parameters to private, removed redundant code, removed initia…
bzizmo Feb 19, 2024
05f3008
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Feb 19, 2024
0f6a160
feat(player): solve remaining conflict:
CarlosVillasenor Feb 19, 2024
87fd178
feat(player): Rename TrackSettingsColors & TrackSettingsFont
CarlosVillasenor Feb 19, 2024
3552329
feat(player): Remove unrequired functions calls from components TextT…
CarlosVillasenor Feb 20, 2024
1972d46
Merge pull request #9 from bzizmo/spatial-nav-refac-focusable
bzizmo Feb 20, 2024
ddd5b12
feat(player): Update spatial-navigation.js's keypress return keyword.
CarlosVillasenor Feb 20, 2024
df799f7
Merge pull request #10 from bzizmo/spatial-nav-refac-keydown
bzizmo Feb 20, 2024
f88ba6e
bind focus and blur just if spatial navigation is enabled, add 1px ga…
bzizmo Feb 20, 2024
e8580e9
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Feb 20, 2024
3ff768d
feat(player): Modify calls on 'isListening' & 'isPaused' for ModalDia…
CarlosVillasenor Feb 20, 2024
deddd0a
Merge branch 'videojs:main' into spatial-navigation
bzizmo Feb 20, 2024
1d84062
feat(player): remove unrequired object on component 'TrackSettingsCon…
CarlosVillasenor Feb 21, 2024
88d66ce
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Feb 21, 2024
b7f8807
Merge pull request #11 from bzizmo/spatial-navigation
bzizmo Feb 21, 2024
c741e8a
Removed 1px gap
bzizmo Feb 21, 2024
51b0e32
feat(player): Rename function ‘getComponents’ to ‘updateFocusableComp…
CarlosVillasenor Feb 21, 2024
825e7a2
Changed SpatialNavigation class to extend EventTarget, removed redund…
bzizmo Feb 22, 2024
af22e40
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Feb 22, 2024
c310238
fix(player): fix call of 'getIsAvailableToBeFocused' that was throwin…
CarlosVillasenor Feb 22, 2024
05a98db
removed Static maps for key presses and extended keycode with the mis…
bzizmo Feb 22, 2024
004db79
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Feb 22, 2024
23c98f1
refactor(player): Modify functions of 'getIsDisabled', 'getIsExpressl…
CarlosVillasenor Feb 23, 2024
ce0683b
Conditional assignment for keycode.codes.back based on platform, chan…
bzizmo Feb 26, 2024
caf1142
Extend the object for reverse lookup, prenet Up/down keys to open a …
bzizmo Feb 27, 2024
147256b
refactor(player): Refactor 'SpatialNavKeycodes' file to not patch 'ke…
CarlosVillasenor Mar 1, 2024
4fb37ed
fix(pllayer): fix issue related to 'back' not being used properly in…
CarlosVillasenor Mar 1, 2024
46b7e24
Merge pull request #12 from bzizmo/spatial-navigation-refactor-keycodes
bzizmo Mar 4, 2024
01afc9d
feat(player): Rename imports of 'spatial-navigation-keycode' to have…
CarlosVillasenor Mar 4, 2024
4db8df4
feat(player): Add example of use of 'Client app uses a global spatial…
CarlosVillasenor Mar 4, 2024
015a537
feat(player): rename 'spatial-navigation-keycode.js' filename
CarlosVillasenor Mar 5, 2024
a574f1b
Merge pull request #14 from bzizmo/spatial-navigation-rename-keycode-…
bzizmo Mar 8, 2024
68f98f6
Merge branch 'videojs:main' into main
bzizmo Mar 8, 2024
4fa895f
Merge branch 'videojs:main' into spatial-navigation
bzizmo Mar 8, 2024
41e5f1b
Fix on src chnage issue, ESC button closing modal, expand vjs-modal-d…
bzizmo Mar 12, 2024
00a8c4c
Merge pull request #15 from bzizmo/spatial-nav-PR-issues
CarlosVillasenor Mar 12, 2024
3170a42
change file name and object name
bzizmo Mar 13, 2024
20814f7
Merge pull request #16 from bzizmo/change-file-name
bzizmo Mar 13, 2024
cc2afe0
Merge branch 'main' of https://github.com/bzizmo/video.js into spatia…
CarlosVillasenor Mar 13, 2024
91a779c
fix: Update ids of labels to use 'guid' so unit test works properly
CarlosVillasenor Mar 14, 2024
927138f
fix: update localized text in text-track-settings-font & text-track-s…
CarlosVillasenor Mar 14, 2024
4df8344
Mark some methods as private
bzizmo Mar 14, 2024
00e8677
fix: modify content of modal 'text-track-settings' to change language…
CarlosVillasenor Mar 14, 2024
5d972bc
Merge pull request #17 from bzizmo/spatial-navigation-fix-text-track-…
bzizmo Mar 14, 2024
750acdb
Merge branch 'videojs:main' into spatial-navigation
bzizmo Mar 14, 2024
361617c
fix: add missing '.' in jsdoc of text-track components
CarlosVillasenor Mar 15, 2024
d394389
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Mar 15, 2024
7a7a11b
feature: add unit test for 'text-track-select' component
CarlosVillasenor Mar 19, 2024
69e7c4f
Add test for Spatial Navigation
bzizmo Mar 20, 2024
b33f051
Merge pull request #18 from bzizmo/spatial-navigation-test
CarlosVillasenor Mar 20, 2024
829da01
test(player): Add minor test related to 'handleBlur' & 'handleFocus'
Mar 20, 2024
b8388ef
feat(player): Remove unrequired files from 'react-video-nav-app'
Mar 20, 2024
9604387
test(player): Add small test to check if 'getPositions' returns requi…
Mar 20, 2024
55f8987
test(player): add test to verify 'getPositions()' properties are not …
CarlosVillasenor Mar 21, 2024
27c480b
Add missing tests for performMediaAction_ and move
bzizmo Mar 21, 2024
34224c8
Merge pull request #19 from bzizmo/missing-spatial-navigation-tests
CarlosVillasenor Mar 21, 2024
1b8f08e
test(player): add test to for 'component.js' related to 'handleBlur'
CarlosVillasenor Mar 21, 2024
96fccee
test(player): add minor test in component related to test keypress pr…
CarlosVillasenor Mar 22, 2024
cca5423
test(player): add test for component related to 'getIsAvailableToBeFo…
CarlosVillasenor Mar 22, 2024
3f27e14
test(player): add test for Modal Dialog related to call function of s…
CarlosVillasenor Mar 22, 2024
7a9e843
test(player): add tests for 'spatial-navigation-key-codes'
CarlosVillasenor Mar 22, 2024
4cc49c6
test(player): add tests for keycodes related to 'should return event …
CarlosVillasenor Mar 22, 2024
0e32e50
test(player): add minor test for case when not required parametters a…
CarlosVillasenor Mar 22, 2024
396fd4f
test(player): add test for 'caption-settings-menu-item'
CarlosVillasenor Mar 23, 2024
6661205
feat(player): remove 'react-video-nav-app'
CarlosVillasenor Apr 7, 2024
47fa98c
Merge branch 'videojs:main' into spatial-navigation
bzizmo Apr 11, 2024
c9249a1
Merge branch 'videojs:main' into spatial-navigation
bzizmo Apr 15, 2024
c8e8d60
Move handleFocus and handleBlur from components.js to spatial-navigat…
bzizmo Apr 15, 2024
fd8a355
Merge pull request #20 from bzizmo/update-component
bzizmo Apr 15, 2024
dada396
refactor(player): refactor 'searchForTrackSelect' to be handled in th…
CarlosVillasenor Apr 15, 2024
c89b7cd
remove unrequired code in function 'searchForTrackSelect'
CarlosVillasenor Apr 16, 2024
e4b6ae2
Merge pull request #21 from bzizmo/spatial-navigation-refactor-search…
bzizmo Apr 16, 2024
e38dd44
update documentation comment to be in pair to its current use
CarlosVillasenor Apr 17, 2024
a53b7b4
remove spatial navigation keydown from modal dialog and move it to sp…
bzizmo Apr 17, 2024
19f6606
Merge branch 'videojs:main' into spatial-navigation
bzizmo Apr 17, 2024
ad25ea0
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
bzizmo Apr 17, 2024
791bdf1
remove useless tests
bzizmo Apr 17, 2024
72e3d07
Merge remote-tracking branch 'origin/update-modal-dialog' into update…
bzizmo Apr 17, 2024
6f99e69
Remove caption-settings-menu-item.test.js
bzizmo Apr 17, 2024
0f32adb
Merge pull request #22 from bzizmo/update-modal-dialog
bzizmo Apr 17, 2024
76827b1
Add minor test to 'searchForTrackSelect' in spatial-navigation.test.js
CarlosVillasenor Apr 17, 2024
010c402
Merge branch 'spatial-navigation' of https://github.com/bzizmo/video.…
CarlosVillasenor Apr 17, 2024
36fb9b5
Add unit test for back key and listening to events
bzizmo Apr 17, 2024
351fe23
Merge remote-tracking branch 'origin/spatial-navigation' into spatial…
bzizmo Apr 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions docs/examples/react-video-nav-app/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*
70 changes: 70 additions & 0 deletions docs/examples/react-video-nav-app/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# Getting Started with Create React App

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).

## Available Scripts

In the project directory, you can run:

### `npm start`

Runs the app in the development mode.\\
Open <http://localhost:3000> to view it in your browser.

The page will reload when you make changes.\\
You may also see any lint errors in the console.

### `npm test`

Launches the test runner in the interactive watch mode.\\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.

### `npm run build`

Builds the app for production to the `build` folder.\\
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.\\
Your app is ready to be deployed!

See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.

### `npm run eject`

**Note: this is a one-way operation. Once you `eject`, you can't go back!**

If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.

You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.

## Learn More

You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

To learn React, check out the [React documentation](https://reactjs.org/).

### Code Splitting

This section has moved here: <https://facebook.github.io/create-react-app/docs/code-splitting>

### Analyzing the Bundle Size

This section has moved here: <https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size>

### Making a Progressive Web App

This section has moved here: <https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app>

### Advanced Configuration

This section has moved here: <https://facebook.github.io/create-react-app/docs/advanced-configuration>

### Deployment

This section has moved here: <https://facebook.github.io/create-react-app/docs/deployment>

### `npm run build` fails to minify

This section has moved here: <https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify>
Loading
Loading