Fix poster-switching tests for IE8, and fix quote handling for other browsers #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When poster() is called with a URL, fire a `posterchange` event to update the PosterImage source and update the video element attribute.
Wait until the tech has updated its poster image before alerting components so they don't see the intermediate state in event handlers. Remove unused variable from PosterImage.createEl.
Create the img fallback for the poster during PosterImage initialization on ie8 so we can avoid having to check and possibly create it each time the src is set. Add a test to ensure that new elements are not appended to the poster component when the img fallback is in use and the src attribute is modified.
added a negative test for an undefined poster
…d properly in the test data) testing: ran the tests at the command line, and in Chrome, Firefox, IE8, IE10, Firefox and Safari all passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed @dmlap's test for IE8. Along the way, I noticed that these tests were failing in Firefox, because Firefox was inserting quotes around the URL in the background-image CSS property. During testing of my fix for IE8, I discovered that IE10 does the same thing as Firefox in terms of inserting those quotes.
This behavior does not affect the player's ability to change the poster image in that or any browser (I manually regression-tested switching poster images in FF, Chrome and IE8).
Since this PR incorporates all of David's previous work for poster switching, I've spoken to him about it, and #833 can be closed.