-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lang): fixes key spacing within fr.json file #7848
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you!
@misteroneill, @gkatsev, can we get this merged and release a patch? |
Codecov Report
@@ Coverage Diff @@
## main #7848 +/- ##
=======================================
Coverage 80.93% 80.93%
=======================================
Files 116 116
Lines 7463 7463
Branches 1813 1813
=======================================
Hits 6040 6040
Misses 1423 1423 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Congrats on merging your first pull request! 🎉🎉🎉 |
@gkatsev, how do we release a patch? |
Just released 7.20.2 as a |
Co-authored-by: Timothy Wittman <[email protected]>
Co-authored-by: Timothy Wittman <[email protected]>
Description
When implementing video.js's option
language
forfr
, we noticed that "Picture-in-Picture" wasn't being translated properly. We noticed #7589 introduced this issue within thefr.json
file.Specific Changes proposed
Please refer to issue #7847
Requirements Checklist