fix: volume control showing up on iOS #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #7514. But turns out, that we still had a timing issue around when we were doing the check and when the volume control was created. Instead, we should make `featuresVolumeControl` not be a lazy property, so, that we do that check as early as possible. Also, we should default this property to `false` in this case, so, that we assume we can't until we confirm we can. Additionally, added a null check for Html5, to be extra defensive since the timeout isn't to a player.
misteroneill
approved these changes
Dec 1, 2021
Codecov Report
@@ Coverage Diff @@
## main #7550 +/- ##
==========================================
- Coverage 80.26% 80.24% -0.02%
==========================================
Files 116 116
Lines 7321 7324 +3
Branches 1769 1770 +1
==========================================
+ Hits 5876 5877 +1
- Misses 1445 1447 +2
Continue to review full report at Codecov.
|
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This is a follow-up to videojs#7514. But turns out, that we still had a timing issue around when we were doing the check and when the volume control was created. Instead, we should make `featuresVolumeControl` not be a lazy property, so, that we do that check as early as possible. Also, we should default this property to `false` in this case, so, that we assume we can't until we confirm we can. Additionally, added a null check for Html5, to be extra defensive since the timeout isn't tied to a player.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #7514. But turns out, that we still had a timing
issue around when we were doing the check and when the volume control
was created.
Instead, we should make
featuresVolumeControlnot be a lazy property,so, that we do that check as early as possible. Also, we should
default this property to
falsein this case, so, that we assume wecan't until we confirm we can.
Additionally, added a null check for Html5, to be extra defensive since
the timeout isn't to a player.