fix: turn off other tracks with native audio track #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio Tracks are supposed to allow multiple tracks at the same time. Safari 15 has added, at least partial support for this. In #7163, we stopped turning other tracks of manually since we already were doing so in the AudioTrackList. However, this only worked for non-native AudioTracks. Before Safari 15, Safari automatically turned off the other tracks for us so things continued to work. With this change, when native audio tracks are used, we will turn off the other tracks, partially reverting #7163. We currently do not have any tests or are set up for writing tests for these proxy tracks. Adding such tests will take too long for not a lot of benefit, unfortunately. Fixes #7494.
Codecov Report
@@ Coverage Diff @@
## main #7519 +/- ##
==========================================
- Coverage 79.84% 79.77% -0.08%
==========================================
Files 116 116
Lines 7309 7316 +7
Branches 1764 1766 +2
==========================================
Hits 5836 5836
- Misses 1473 1480 +7
Continue to review full report at Codecov.
|
misteroneill
approved these changes
Nov 16, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Audio Tracks are supposed to allow multiple tracks at the same time. Safari 15 has added, at least partial support for this. In videojs#7163, we stopped turning other tracks of manually since we already were doing so in the AudioTrackList. However, this only worked for non-native AudioTracks. Before Safari 15, Safari automatically turned off the other tracks for us so things continued to work. With this change, when native audio tracks are used, we will turn off the other tracks, partially reverting videojs#7163. We currently do not have any tests or are set up for writing tests for these proxy tracks. Adding such tests will take too long for not a lot of benefit, unfortunately. Fixes videojs#7494.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio Tracks are supposed to allow multiple tracks at the same time.
Safari 15 has added, at least partial support for this.
In #7163, we stopped turning other tracks of manually since we already
were doing so in the AudioTrackList. However, this only worked for
non-native AudioTracks. Before Safari 15, Safari automatically turned
off the other tracks for us so things continued to work.
With this change, when native audio tracks are used, we will turn off
the other tracks, partially reverting #7163.
We currently do not have any tests or are set up for writing tests for
these proxy tracks. Adding such tests will take too long for not a lot
of benefit, unfortunately.
Fixes #7494.