Add a player option noUITitleAttributes to prevent title attributes in the UI (fixes #6767).
#7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the UI (fixes videojs#6767).
OwenEdwards
added
the
a11y
|
I need to add documentation in docs/guides/options.md before this is ready to merge. |
OwenEdwards
commented
Mar 13, 2021
| @@ -28,8 +28,11 @@ | |||
| * [language](#language) | |||
| * [languages](#languages) | |||
| * [liveui](#liveui) | |||
| * [liveTracker.trackingThreshold](#livetrackertrackingthreshold) | |||
| * [liveTracker.liveTolerance](#livetrackerlivetolerance) | |||
There was a problem hiding this comment.
I don't know where these two lines came from?! I can remove them?
There was a problem hiding this comment.
If you've run npm run docs:fix, it probably added these two items that were added to the doc but we missed updating the TOC with them. #7097
There was a problem hiding this comment.
@gkatsev so it would be okay to merge this change and let those two lines get added in options.md? Or would you prefer to have them in a separate PR?
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…ibutes in the UI (videojs#7134) Fixes videojs#6767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some designers and developers feel that the presence of (redundant)
titleattribute values on UI controls makes the accessibility of those controls worse. The title attributes can also conflict with additions to make truly accessible tooltips on the controls.This PR allows developers to easily disable the addition of
titleattributes on all UI controls with a single player configuration option.Specific Changes proposed
Add a player option
noUITitleAttributeswhich, if set totrue, prevents video.js from adding anytitleattributes to UI controls.Requirements Checklist