Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up preventDefault error on Android #7063

Merged

Conversation

ckybonist
Copy link
Contributor

Description

Focus on video player and scroll will raise the error

Ignored attempt to cancel a touchend event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

image

To reproduce the error:

  1. Put your finger on video player (do not lift up the finger)
  2. Scroll up and down

Specific Changes proposed

Check event.cancelable before executing event.preventDefault

see: https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault#notes

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jan 25, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like cancelable should be supported most places, so, LGTM

@gkatsev gkatsev merged commit b13cb07 into videojs:main Jan 25, 2021
@welcome
Copy link

welcome bot commented Jan 25, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@ckybonist ckybonist deleted the check-cancelable-before-prevent-default branch January 26, 2021 03:04
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants