Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use clamp correctly in progress control #6625

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

brandonocasey
Copy link
Contributor

Description

This was brought to our attention by a comment on #6155 https://github.com/videojs/video.js/pull/6155/files#r416763642

It seems that I used clamp wrong in that pull request. and this is the fix for it.

Copy link
Member

@OwenEdwards OwenEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkatsev gkatsev changed the base branch from master to main June 19, 2020 19:06
@gkatsev gkatsev merged commit cad9114 into main Jun 19, 2020
@gkatsev gkatsev deleted the fix/incorrect-clamp-usage branch June 19, 2020 19:06
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants