Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): allow middleware to handle muted setter/getter #6177

Merged
merged 27 commits into from
Aug 29, 2019

Conversation

gjanblaszczyk
Copy link
Member

Description

Allow middleware to handle muted setter and getter. This supports things like muting the media programmatically, without affecting the player's UI muted button control.

Specific Changes proposed

Add muted setter and getter to the lists of allowed Getters and Setters in the middleware feature.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gjanblaszczyk and others added 27 commits September 3, 2018 11:07
sync with origin branch
@gkatsev gkatsev added the minor This PR can be added to a minor release. It should not be added to a patch release. label Aug 21, 2019
@gkatsev gkatsev merged commit f324d1f into videojs:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants