Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Cloning native events is no longer needed #6153

Closed
wants to merge 1 commit into from

Conversation

brandonocasey
Copy link
Contributor

As the title says, it appears that we no longer need to clone the event objects from the browser, we can just use the browser object. seems to work on all the browsers I tested with: IE 11, Safari 12/11, Android Chrome, Chrome, Firefox, Edge, iOS

@gkatsev
Copy link
Member

gkatsev commented Aug 1, 2019

There are some event object properties that are read-only (like defaultPrevented) that we set. It's possible that we may not need to fix events anymore but more investigating would be required into what other changes should happen.

@brandonocasey
Copy link
Contributor Author

I agree, this change would need a lot of testing before we could bring it in

@gkatsev
Copy link
Member

gkatsev commented Aug 5, 2019

Since we're making sure we're not going to fix events multiple times as part of #6145, should we close this out until we can investigate this more?

@brandonocasey
Copy link
Contributor Author

We probably still want to look into doing this as fixEvent still takes significant time for each event.

@brandonocasey
Copy link
Contributor Author

I am opening an issue for this #6175 as I don't think we will have the time to get to this, as its a bigger change that will need a lot of testing.

@brandonocasey brandonocasey deleted the perf/fix-event-no-old branch August 12, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants