chore: use the new any event function
#6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/use-event-any
branch
from
162347a to
722bd5f
Compare
gkatsev
reviewed
Jul 29, 2019
| this.tech_.any(['sourceset', 'loadstart'], (e) => { | ||
| // if a sourceset happens before a `loadstart` there | ||
| // is nothing to do as this function will be called again. | ||
| if (e.type === 'sourceset') { |
There was a problem hiding this comment.
Using .any, I'm not sure that this function will get called again anymore.
There was a problem hiding this comment.
I think the comment needs to be updated to say that handleTechSourceset will be called again and reset the cache, rather than "this function"
There was a problem hiding this comment.
Oh, I see, we called off unconditionally previously as well. It looked like we didn't.
There was a problem hiding this comment.
I updated the comment now.
gkatsev
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new
anyevent function where it makes sense.