fix: add use of the safe version of getComputedStyle #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add use of the safe version of computedStyle in the currentDimension method of Component's class. This will prevent a null exception when a video.js is implemented in a 'display:none' iframe on Firefox (<62). This is a fix in continuation of the MR#3664 regarding a bug in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=548397
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
| @@ -26,9 +26,9 @@ function computedStyle(el, prop) { | |||
| } | |||
|
|
|||
| if (typeof window.getComputedStyle === 'function') { | |||
| const cs = window.getComputedStyle(el); | |||
| const computedStyleValue = window.getComputedStyle(el); | |||
There was a problem hiding this comment.
maybe this should just be called style? That is what they use on mdn
There was a problem hiding this comment.
Are you referring to this page?
https://developer.mozilla.org/fr/docs/Web/API/Window/getComputedStyle
They also use cs in the examples, but I'm not a fan of very short abbreviations or too much generic term where you have to go back to the declaration to understand exactly the variable.
Do you want me to change my commit to use the name style?
gkatsev
approved these changes
Jul 29, 2019
| @@ -26,9 +26,9 @@ function computedStyle(el, prop) { | |||
| } | |||
|
|
|||
| if (typeof window.getComputedStyle === 'function') { | |||
| const cs = window.getComputedStyle(el); | |||
| const computedStyleValue = window.getComputedStyle(el); | |||
brandonocasey
approved these changes
Jul 29, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add use of the safe version of getComputedStyle in the currentDimension method of Component's class.
This will prevent a null exception when a video.js is implemented in a 'display:none' iframe on Firefox (<62).
This is a fix in continuation of the MR #3664 regarding a bug in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=548397
Specific Changes proposed
Requirements Checklist