'Esc' works for a vertical volume bar and menus #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with origin branch
gjanblaszczyk
changed the title
gkatsev
reviewed
Jul 29, 2019
|
Hi @gkatsev, Yes, exactly. I had the same issue that was recently reported by |
gkatsev
approved these changes
Aug 19, 2019
misteroneill
requested changes
Aug 19, 2019
src/js/control-bar/volume-panel.js
Outdated
|
|
||
| /** | ||
| * Handles `keydown|keyup` events on the document, looking for ESC, which closes | ||
| * the volume panel. |
There was a problem hiding this comment.
Looks like a copy/paste issue here.
There was a problem hiding this comment.
Thanks, nice catch! I have just fixed the comment.
src/js/control-bar/volume-panel.js
Outdated
| */ | ||
| handleKeyPress(event) { | ||
| if (keycode.isEventKey(event, 'Esc')) { | ||
| this.removeClass('vjs-hover'); |
There was a problem hiding this comment.
I think we also need to remove the document-level listener here?
There was a problem hiding this comment.
Thanks, I have just improved the method following your comment.
misteroneill
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #6004 , this PR adds support for 'Esc' functionality in the volume bar and menus.
Specific Changes proposed
The PR improves player accessibility by adding 'Esc' functionality to the volume panel and menu popups.
Requirements Checklist