-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Picture-in-Picture API methods #6001
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Can an "abstract"/empty method be added to |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
We try to have two core contributors review PRs before they're merged but this is definitely on the way! Thanks again! |
@gkatsev Hopefully it's gonna be OK then. Thanks for reviewing ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized promises may not be available by default.
@gkatsev I think we're good now. WDYT? |
Congrats on merging your first pull request! 🎉🎉🎉 |
* | ||
* @listens focus | ||
*/ | ||
handleFocus(event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkatsev Why we need handleFocus
here? I thought it should be removed... and this.boundHandleKeyPress_
doesn't exist inside the player class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. This change was not part of my proposed changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... must've snuck in when I was fixing merge conflicts. I'll make sure that it's fixed in master. Nice find @gjanblaszczyk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to re-remove them: #6053
Jsut a quick question, how do I disable the picture in picture button from the player init options? |
@GeoTimber see the option here #6002 (comment) |
Description
Following #5824 (comment), this PR adds support for some Picture-in-Picture methods described in the spec and article
Specific Changes proposed
This PR is about entering and leaving Picture-in-Picture in the player. It also makes sure that we can listen to the
enterpictureinpicture
andleavepictureinpicture
events on the player.Requirements Checklist