Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate @deprecated which throws error when minifying via go… #5342

Merged
merged 1 commit into from
Jul 24, 2018
Merged

remove duplicate @deprecated which throws error when minifying via go… #5342

merged 1 commit into from
Jul 24, 2018

Conversation

mreinstein
Copy link
Contributor

remove duplicate @deprecated which throws error when minifying via google closure compiler

jsdoc doesn't allow duplicate tags for a given function header. This is the only place in the project where this rule isn't respected. This change causes closure compiler to run without errors or warnings.

@welcome
Copy link

welcome bot commented Jul 24, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@gkatsev gkatsev merged commit d773cd4 into videojs:master Jul 24, 2018
@welcome
Copy link

welcome bot commented Jul 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants