-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for #4583 (JAWS+IE doesn't announce BPB or play button) #5173
Workaround for #4583 (JAWS+IE doesn't announce BPB or play button) #5173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable.
Another workaround, which is probably not as good, is to add a dummy button element immediately after the video element for JAWS to swallow up.
@gkatsev the problem with that is that focus will still move to that dummy button (if not, it doesn't fix the problem), and that dummy button will be unlabeled, which isn't good. Hopefully Freedom Scientific/JAWS will fix this issue soon, but even then it will still work with this workaround since it's a workaround that they proposed themselves, so they'd be really shooting themselves in the foot if they fixed the problem in JAWS and afterward it didn't work with their own workaround! |
yeah makes sense. This is definitely the better workaround. |
There is no reason why the 'workaround' will have any negative effects if/when the JAWS+IE issues is resolved. Use of |
…5206) Freedom Scientific's recommended workaround for JAWS + IE not announcing the first button after a video element which doesn't have its own native controls (See FreedomScientific/standards-support#78). This is the 6.x version of #5173 (2bc810d). Fixes #4583
Description
Workaround for #4583 (JAWS+IE doesn't announce BPB or play button)
Specific Changes proposed
Add ARIA
role="application"
to the<video>
element if the browser is IE, as recommended by @stevefaulkner in FreedomScientific/standards-support#78 (comment).Requirements Checklist