Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: options.id is now applied correctly to the player dom element #5090

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix: options.id is now applied correctly to the player dom element #5090

merged 1 commit into from
Apr 19, 2018

Conversation

axten
Copy link
Contributor

@axten axten commented Apr 12, 2018

Description

see #5088

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gkatsev
gkatsev approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Apr 12, 2018
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Apr 19, 2018
@gkatsev gkatsev merged commit b10b9f9 into videojs:master Apr 19, 2018
gkatsev pushed a commit that referenced this pull request Apr 19, 2018
@axten @gkatsev
fix: options.id is now applied correctly to the player dom element (#…
d4dbb21 
…5090)

Fixes #5088
gkatsev pushed a commit that referenced this pull request Apr 20, 2018
@axten @gkatsev
fix: options.id is now applied correctly to the player dom element (#…
dd45dc0 
…5090)

Fixes #5088
@gkatsev gkatsev mentioned this pull request Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axten @misteroneill @gkatsev