Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: built-in HLS playback support #4961

Closed
wants to merge 1 commit into from
Closed

Conversation

forbesjo
Copy link
Contributor

@forbesjo forbesjo commented Feb 16, 2018

Description

This PR is to start the conversation for adding HLS playback support built into video.js for 7.0 via videojs-http-streaming (shorthand VHS). VHS is the next major version of videojs-contrib-hls that removes HLS Flash playback and includes some experimental DASH support (hence the rename). The purpose is to improve the out-of-the-box experience for video.js and allow cross browser HLS compatibility.

Todos:

  • Resolve the webworkify issue in order to support webpack Support for webpack? videojs-contrib-hls#600
  • Determine how we'll create builds with and without VHS (if a user prefers to use hls.js)
  • Resolve any API changes video.js requires and version 1.0.0 VHS

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Feb 16, 2018

Looks like there are other, potentially related issues with the build: https://travis-ci.org/videojs/video.js/builds/342401866#L3557
but hurray for getting things started!

@forbesjo
Copy link
Contributor Author

Since the webworker plugin will only work with browserify and webpack let's consider switching from rollup to webpack in video.js

@gkatsev gkatsev added the major label Mar 6, 2018
@brandonocasey
Copy link
Contributor

started some webpack work awhile ago in #4985

@gkatsev
Copy link
Member

gkatsev commented Mar 15, 2018

Thanks @brandonocasey. I'm going to be switching to webpack work tomorrow.

@forbesjo forbesjo force-pushed the vhs branch 2 times, most recently from cbe1acb to 892f1e2 Compare March 22, 2018 16:08
@forbesjo
Copy link
Contributor Author

Closing in favor of #5053

@forbesjo forbesjo closed this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants