feat: player resize event #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger a playerresize event when the player is resized using the API Fixes videojs#4629
Allows us to avoid triggering the resize event twice when setting both width and height at once
gkatsev
approved these changes
Dec 11, 2017
|
Given that we're adding a new event, this would be a |
gkatsev
added
minor
|
Also, thanks for adding tests! |
ldayananda
added
confirmed
and removed
needs: LGTM
10 tasks
gkatsev
added a commit
that referenced
this pull request
Jan 30, 2018
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player. Allows a video.js user to disable this by setting resizeManager: false as an option since the component will not be initialized. Add a debounce util. This reverts #4800 (e0ed0b5) because we end up getting two playerresize events with the dimension methods now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4629, and also handles multi-dimensional resizing correctly. I.e.
playerresizeevent is only triggered once when width and height is changed at once (usingComponent#dimensions).Specific Changes proposed
Trigger a
playerresizeevent inPlayer#dimensionifPlayer.isReady_andskipListenersis falsy.skipListenersis added as an optional parameter to the following methods:Player#width,Player#height, andPlayer#dimension. This parameter can be used to skip theplayerresizeevent trigger.Requirements Checklist