Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore: get rid of redundant test logging #4682

Merged
merged 1 commit into from
Oct 23, 2017
Merged

ignore: get rid of redundant test logging #4682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions test/unit/tracks/text-track-display.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ QUnit.test('shows the default caption track first', function(assert) {
};

// Add the text tracks
const englishTrack = player.addRemoteTextTrack(track1).track;
const spanishTrack = player.addRemoteTextTrack(track2).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;
const spanishTrack = player.addRemoteTextTrack(track2, true).track;

// Make sure the ready handler runs
this.clock.tick(1);
Expand All @@ -116,7 +116,7 @@ if (!Html5.supportsNativeTextTracks()) {
const selectedLanguageHandler = function(event) {
spy();
};
const englishTrack = player.addRemoteTextTrack(track1).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;

player.textTracks().addEventListener('selectedlanguagechange', selectedLanguageHandler);
englishTrack.mode = 'showing';
Expand All @@ -138,7 +138,7 @@ if (!Html5.supportsNativeTextTracks()) {

player.src({type: 'video/mp4', src: 'http://google.com'});
// manualCleanUp = true by default
const englishTrack = player.addRemoteTextTrack(track1).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;

// Force 'es' as user-selected track
player.cache_.selectedLanguage = { language: 'es', kind: 'captions' };
Expand Down Expand Up @@ -170,8 +170,8 @@ if (!Html5.supportsNativeTextTracks()) {

player.src({type: 'video/mp4', src: 'http://google.com'});
// manualCleanUp = true by default
const englishTrack = player.addRemoteTextTrack(track1).track;
const spanishTrack = player.addRemoteTextTrack(track2).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;
const spanishTrack = player.addRemoteTextTrack(track2, true).track;

// Force 'es' as user-selected track
player.cache_.selectedLanguage = { enabled: true, language: 'es', kind: 'captions' };
Expand Down Expand Up @@ -199,8 +199,8 @@ if (!Html5.supportsNativeTextTracks()) {

player.src({type: 'video/mp4', src: 'http://google.com'});
// manualCleanUp = true by default
const captionTrack = player.addRemoteTextTrack(track1).track;
const subsTrack = player.addRemoteTextTrack(track2).track;
const captionTrack = player.addRemoteTextTrack(track1, true).track;
const subsTrack = player.addRemoteTextTrack(track2, true).track;

// Force English captions as user-selected track
player.cache_.selectedLanguage = { enabled: true, language: 'en', kind: 'captions' };
Expand Down Expand Up @@ -233,8 +233,8 @@ if (!Html5.supportsNativeTextTracks()) {

player.src({type: 'video/mp4', src: 'http://google.com'});
// manualCleanUp = true by default
player.addRemoteTextTrack(track1);
player.addRemoteTextTrack(track2);
player.addRemoteTextTrack(track1, true);
player.addRemoteTextTrack(track2, true);

// Keep track of menu items
esCaptionMenuItem = getMenuItemByLanguage(captionsButton.items, 'es');
Expand All @@ -261,8 +261,8 @@ if (!Html5.supportsNativeTextTracks()) {
// change the kind of track to subtitles
track1.kind = 'subtitles';
track2.kind = 'subtitles';
const englishTrack = player.addRemoteTextTrack(track1).track;
const spanishTrack = player.addRemoteTextTrack(track2).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;
const spanishTrack = player.addRemoteTextTrack(track2, true).track;

// Make sure player ready handler runs
this.clock.tick(1);
Expand Down Expand Up @@ -298,7 +298,7 @@ if (!Html5.supportsNativeTextTracks()) {

player.src({type: 'video/mp4', src: 'http://google.com'});
// manualCleanUp = true by default
const englishTrack = player.addRemoteTextTrack(track1).track;
const englishTrack = player.addRemoteTextTrack(track1, true).track;
// Keep track of menu items
const enCaptionMenuItem = getMenuItemByLanguage(captionsButton.items, 'en');

Expand Down