6.x: fix: synchronously shim vtt.js when possible #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
changed the title
misteroneill
approved these changes
Feb 14, 2017
| @@ -551,7 +558,10 @@ class Tech extends Component { | |||
| // we don't overwrite the injected window.WebVTT if it loads right away | |||
| window.WebVTT = true; | |||
| this.el().parentNode.appendChild(script); | |||
| } else { | |||
| this.ready(this.addWebVttScript_); | |||
There was a problem hiding this comment.
Nice, glad to see this change from an event listener. I was going to mention that could cause problems with multiple ready events. 💯
brandonocasey
changed the title
|
browerstack is being weird when testing IE11, locally tests work. Going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #4082
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist