If we create a new element for movingMediaElInDOM, set playerId on the el again #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably be rebased against stable and released as a patch along with the other items we have there. |
gkatsev
added
patch
|
I noticed this was updating the Html5 tech. Is there any reason/need to update the Flash tech or is this isolated to Html5? |
|
It should only be an issue for when we delete and re-create the mediaEl. The original tag already gets the |
|
Sounds good. LGTM |
brandonocasey
approved these changes
Sep 20, 2016
gkatsev
removed
needs: LGTM
|
Closing in favor of #3648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3283. When
videojsis called with an element, we try to see if we already have a player for that element. In some cases, like ifdata-setupis used with a manual call tovideojs, we get called multiple times with the same element. On iOS, we cannot move the media element inside the DOM, so, we recreate it. In the process, we lose a marker we use for knowing whether we've created a player for that element.This makes sure we keep that marker if we re-create the element.