Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build webpack test file during tests #3579

Closed
wants to merge 1 commit into from
Closed

build webpack test file during tests #3579

wants to merge 1 commit into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Aug 25, 2016

@brandonocasey
Copy link
Contributor

is there anyway to make that warning into an error?

@gkatsev
Copy link
Member Author

gkatsev commented Aug 25, 2016

Can't find anything.

@brandonocasey
Copy link
Contributor

brandonocasey commented Aug 25, 2016 •
edited
Loading

should this be run on test as well? scratch that it is

@brandonocasey
Copy link
Contributor

LGTM

@gkatsev gkatsev added confirmed minor This PR can be added to a minor release. It should not be added to a patch release. labels Aug 25, 2016
@gkatsev gkatsev closed this in daab267 Aug 25, 2016
@gkatsev gkatsev deleted the test-webpack branch August 25, 2016 20:25
helenjer pushed a commit to helenjer/video.js that referenced this pull request Sep 6, 2016
@gkatsev
@gkatsev added webpack to test build. closes videojs#3579
005f504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @brandonocasey