-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework build to seperate out ie8 specific sass #3380
Conversation
Moving the IE8 stuff to another sass file, unfortunately, won't fix the issue. It needs to be turned into a plain old css file (so, sass won't turn the special characters into utf8/unicode characters). |
Also, wanted to thank you for getting started on this. Let me know if you can get to the changes above, otherwise, I can probably pull your changes in and make the other changes as well. |
gotcha. Thanks for the extra clarifications @gkatsev - I should be able to take care of this. No worries at all. |
the only thing outstanding is that the unminified |
Having the temp file not include the ie8 piece is fine, I think. |
While I think that |
Ah, we can use |
Made a PR for this, see https://github.com/erikyuzwa/video.js/pull/1 |
Love this. LGTM. |
landed in d86d4b2 and 1ff9f38. |
Description
IE8
and create its own separate.css
file if needed by developersSpecific Changes proposed
src/css/ie8.scss
to capture all ie8 specific sass.src/css/components/_control-bar.scss
which were ie8 specific.grunt build
task to support this.Requirements Checklist