Add descriptions and audio button to adaptive classes #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buttons for descriptions and audio tracks were recently added, but not yet hidden by the adaptive classes, as their siblings chapters, subtitles etc are. Fixes videojs#3308
|
Thanks @hartman, LGTM. |
gkatsev
added
patch
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 5.9, a button for descriptions was added to the control bar and in 5.10 a button for audio tracks. Unlike their chapter, captions, subtitle counterparts these were not hidden by the adaptive classes.
Specific Changes proposed
Add these new buttons to the list of buttons hidden in smaller form factor layouts.
Requirements Checklist
This fixes #3308