Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minified videojs in ie8 #3104

Closed
wants to merge 3 commits into from
Closed

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 11, 2016

The issue here is that babel was turning function expressions like let Foo = function() {}
in names function expressions like var Foo = function Foo() {}. Afterwards, the minifier came through and cause these two variables to diverge causing issues in IE8. The fix is to switch to function statements.
Fixes #3064 and #3070.

@gkatsev gkatsev added bug patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals in progress labels Feb 11, 2016
@gkatsev
Copy link
Member Author

gkatsev commented Feb 11, 2016

This is only a problem because of the special handling we do for tracks in IE8, specifically:

if (browser.IS_IE8) {
tt = document.createElement('custom');
for (let prop in TextTrack.prototype) {
if (prop !== 'constructor') {
tt[prop] = TextTrack.prototype[prop];
}
}
}

@misteroneill
Copy link
Member

LGTM then

@gkatsev gkatsev closed this in a2f5430 Feb 11, 2016
@gkatsev gkatsev deleted the fix-ie8-min branch February 11, 2016 22:06
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in progress patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

video.min.js errors in IE8, must use video.js
2 participants