Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix track tests and ignore empty properties in tracks #2744

Closed
wants to merge 3 commits into from
Closed

Fix track tests and ignore empty properties in tracks #2744

wants to merge 3 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Oct 26, 2015

No description provided.

This was referenced Oct 26, 2015
Closed
Closed
@pam
Copy link

pam commented Oct 26, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: d26a646
Build details: https://travis-ci.org/pam/video.js/builds/87566307

(Please note that this is a fully automated comment.)

@gkatsev
Copy link
Member Author

gkatsev commented Oct 26, 2015

Super weird that travis still hasn't replied since it actually passed.

@gkatsev
Copy link
Member Author

gkatsev commented Oct 26, 2015

@pam retry

1 similar comment
@gkatsev
Copy link
Member Author

gkatsev commented Oct 26, 2015

@pam retry

@pam
Copy link

pam commented Oct 26, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: d26a646
Build details: https://travis-ci.org/pam/video.js/builds/87567160

(Please note that this is a fully automated comment.)

@gkatsev
Copy link
Member Author

gkatsev commented Oct 26, 2015

@pam retry

@pam
Copy link

pam commented Oct 26, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: d26a646
Build details: https://travis-ci.org/pam/video.js/builds/87570911

(Please note that this is a fully automated comment.)

@gkatsev
Copy link
Member Author

gkatsev commented Oct 26, 2015

If travis ever updates this, it'll be all green. But it actually is all green!

@misteroneill
Copy link
Member

LGTM

@gkatsev gkatsev closed this in ab88bcd Oct 27, 2015
@gkatsev gkatsev deleted the fix-track-tests-rebased branch October 27, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkatsev @pam @misteroneill