Added an 'attributes' arg to createEl() #2589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We originally were accepting both properties and attributes in the | ||
| // same object, but that doesn't work so well. | ||
| if (propName.indexOf('aria-') !== -1 || propName === 'role' || propName === 'type') { | ||
| log.warn(`Setting attributes in the second argument of createEl() |
There was a problem hiding this comment.
does this have a bunch of extra whitespace in it? Might want to grab https://www.npmjs.com/package/tsml
|
LGTM, we probably want to mention this in the wiki for the 5.0 transition. |
|
Yeah, good point. I'll add it. On Mon, Sep 14, 2015 at 8:38 PM, Gary Katsevman [email protected]
|
| @@ -29,25 +31,28 @@ export function getEl(id){ | |||
| * @return {Element} | |||
| * @function createEl | |||
| */ | |||
| export function createEl(tagName='div', properties={}){ | |||
| export function createEl(tagName='div', properties={}, attributes={}){ | |||
There was a problem hiding this comment.
the jsdocs for this were never added.
Also, we should probably document exactly what the different between the two would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2176
Properties and attributes need to be handled separately in createEl(). This adds a third arg for attributes and a deprecation warning for the cases were we expected attributes to come through the properties object.