IE8 JScript_DontEnum_Bug #2565
IE8 JScript_DontEnum_Bug #2565
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: ea27f2e (Please note that this is a fully automated comment.) |
|
I really want to contribute my strength, but I don't know why I build failed, I just added a Conditional statements When I filter the 'constructor ',it run success |
|
The build failed because of linting errors, see the output here: https://travis-ci.org/videojs/video.js/builds/79115792#L120-L126 |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 59eb698 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: ffd7fee (Please note that this is a fully automated comment.) |
| @@ -21,7 +21,9 @@ let TextTrackCueList = function(cues) { | |||
| list = document.createElement('custom'); | |||
|
|
|||
| for (let prop in TextTrackCueList.prototype) { | |||
| list[prop] = TextTrackCueList.prototype[prop]; | |||
| if(prop!=='constructor'){ | |||
There was a problem hiding this comment.
Some style updates:
- space after
if - space around operator (
!==) - space before opening
{
Also below.
|
Looks good, other than a minor stylistic issue. If you can update it, I'll be happy to merge it in. |
edit code style
edit code style
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 33c6293 (Please note that this is a fully automated comment.) |
|
Awesome, thanks. I'll get that merged in tomorrow. |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: ed2363b (Please note that this is a fully automated comment.) |
|
I feel very honored ^_^ |
|
LGTM |
there have some question in my projects, when I run video.js on IE8.
throw the exception "SCRIPT3: 找不到成员。"
I'll google a lot of information, I finally found this
https://developer.mozilla.org/en-US/docs/ECMAScript_DontEnum_attribute#JScript_DontEnum_Bug
Reproducing this bug:[run context:ie8]
var testEle=document.createElement('custom');
testEle['constructor']=function(){} ;//or testEle.constructor=function(){}
solution:avoid all of the pitfalls