Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix texttrack handling in IE10 #2481

Closed
wants to merge 1 commit into from
Closed

Fix texttrack handling in IE10 #2481

wants to merge 1 commit into from

Conversation

nickygerritsen
Copy link
Contributor

Apparantly IE10 does have textTracks on the video element, but does not support addEventListener and removeEventListener on it.

This should fix that problem.

@gkatsev
Copy link
Member

gkatsev commented Aug 14, 2015

haha, I had that in my code but removed it. Does IE10 allow for us to listen for events on the textTracks? Or does it also not support it? In which case, we should disable it like we did IE10.

@nickygerritsen
Copy link
Contributor Author

IE10 gives undefined for tt.addEventListener (and also for the remove). So I think we should remove it

@gkatsev
Copy link
Member

gkatsev commented Aug 14, 2015

is onremovetrack or onaddtrack available on the element?

@nickygerritsen
Copy link
Contributor Author

Oh just left work so I can only check much later

@heff
Copy link
Member

heff commented Aug 14, 2015

Bah...I told @gkatsev to remove the check. My bad!

@nickygerritsen
Copy link
Contributor Author

I tried to figure out if onaddtrack and onremovetrack are there, but both in IE and in Chrome if I output vid.textTracks.onaddtrack in the console I get nothing, so not really sure how to find out if this exists.

@gkatsev
Copy link
Member

gkatsev commented Aug 18, 2015

If IE outputs nothing a falsey value for 'onremovetrack' in vid.textTracks, then we should already be disabling native functionality (https://github.com/videojs/video.js/blob/master/src/js/tech/html5.js#L896-L898). Though, I guess we still need this because we might still be trying to bind and unbind the handlers.

@heff
Copy link
Member

heff commented Aug 19, 2015

lgtm

@gkatsev gkatsev closed this in 33de008 Aug 19, 2015
@gkatsev
Copy link
Member

gkatsev commented Aug 19, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants