Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vertical Slider #2469

Closed
wants to merge 3 commits into from
Closed

Fix Vertical Slider #2469

wants to merge 3 commits into from

Conversation

misteroneill
Copy link
Member

  • Updates how a slider determines whether it's vertical to use the vertical() method instead of referring to the option value. Conceivably the vertical() method could be called to update the vertical_ property which would get it out of sync with the option value.
  • Removed the unused handle-related code.
  • Some minor formatting changes.

@mmcc
Copy link
Member

mmcc commented Aug 12, 2015

👍 lgtm

@heff
Copy link
Member

heff commented Aug 12, 2015

lgtm

@gkatsev gkatsev closed this in 79e5888 Aug 19, 2015
@misteroneill misteroneill deleted the fix-vertical-slider branch September 8, 2015 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misteroneill @mmcc @heff