Add seekable attribute #2207
Add seekable attribute #2207
Conversation
Export the seekable player attribute and implement it based on duration in the Flash tech.
|
This is kind of an uncomfortable change for a patch release. What's it going to be used for? |
|
It's not really possible to build a (standards-based) live DVR UI without seekable. I agree it's not a good time in the release cycle to make a change like this but it's going to be a while until contrib-hls can migrate to 5.0. |
| @@ -617,6 +617,18 @@ vjs.round = function(num, dec) { | |||
| * @private | |||
| */ | |||
| vjs.createTimeRange = function(start, end){ | |||
| if (start === undefined && end === undefined) { | |||
There was a problem hiding this comment.
Is there a reason why we wouldn't throw an error when you try to create a time range with no start/end values, instead of creating one that throws errors later?
There was a problem hiding this comment.
Ok, apparently that's how native time ranges work.
var v = document.createElement('video').buffered.start(0);
Uncaught DOMException: Failed to execute 'start' on 'TimeRanges': The index provided (0) is greater than or equal to the maximum bound (0).
There was a problem hiding this comment.
Yep, that's what I was emulating.
|
Offline 👍 from @heff. We don't want to make enhancements like this to 4.x right now but 5.0 is not at release candidate yet. |
Export the seekable player attribute and implement it based on duration in the Flash tech.