Add get and set global options methods #2115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I need to update the sandbox. |
| @@ -42,6 +43,11 @@ videojs.players = Player.players; | |||
|
|
|||
| videojs.extends = extendsFn; | |||
|
|
|||
| videojs.getGlobalOptions = () => options; | |||
There was a problem hiding this comment.
If we're going to start using fat arrows, make sure to make a note in the ES6 page on the wiki.
There was a problem hiding this comment.
I'll add a note. I decided to use it here specifically because this function becomes so short as a fat arrow function.
|
👍 |
|
LGTM. Can you also add a note to the 5.0 changes wiki? This is actually a pretty significant change considering it's used in most example embeds. https://github.com/videojs/video.js/wiki/5.0-Change-Details |
|
I'll get to that soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final part of #1998