Fixed setting the source to an empty string #1905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| vjs.MediaTechController.withSourceHandlers(Tech); | ||
|
|
||
| Tech.nativeSourceHandler = { | ||
| handleSource: function(){ usedNative = true; } |
There was a problem hiding this comment.
I don't love the weird indirection here. Why not just do the assertion right in this callback and set the number of expected assertions to 1?
|
Otherwise 👍 |
|
Cleaned up the test order |
| @@ -229,3 +229,25 @@ test('should add the source hanlder interface to a tech', function(){ | |||
| tech.dispose(); | |||
| ok(disposeCalled, 'the handler dispose method was called when the tech was disposed'); | |||
| }); | |||
|
|
|||
| test('should handle unsupported sources with the source hanlder API', function(){ | |||
jgubman
added a commit
to jgubman/video.js
that referenced
this pull request
Apr 16, 2015
* 'stable' of https://github.com/videojs/video.js: (115 commits) Release v4.12.5 Updated to videojs-swf v4.5.4 to fix a potential security issue. closes videojs#1955 Release v4.12.4 Randomized the Google Analytics calls to stay under the limit. closes videojs#1916 Release v4.12.3 added bin file for returning the current version @heff fixed setting the source to an empty string. closes videojs#1905 Switched to grunt-aws-s3 for CDN uploads Release v4.12.2 manually tag before github-release remove tagrelease and commit unstaged changes manually (github-release handles tagging) fixing undefined package reference in cdn-links task @gkatsev fixed disabling of default text tracks. closes videojs#1892 breaking grunt tasks out into separate files to clean up the main Gruntfile. Also removed unused requires from the primary Gruntfile and making sure they are in the appropriate task file. Release 4.12.1 Only rely on selectedIndex to set select option. Firefox recently added selectedOptions support, however, unlike chrome and other browsers, they made it read-only and have it throw an error. In my testing (via http://jsfiddle.net/vwvdywf9/), on various browsers and platforms, just using selectedIndex was sufficient to change the selected option. Store text tracks on player not tech Moved s3 config to environment variables Release 4.12.0 Cleaned up inconsistencies in the changelog ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1785