Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen updates for iOS #1511

Closed
wants to merge 9 commits into from
Closed

Fullscreen updates for iOS #1511

wants to merge 9 commits into from

Commits on Sep 16, 2014

  1. Export isFullScreen correctly. Export isFullscreen as well.

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    fe4a8fb View commit details
    Browse the repository at this point in the history

  2. On iOS, use ios specific enterFullscreen methods.

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    e423635 View commit details
    Browse the repository at this point in the history

  3. Update exports for request & cancel fullscreen

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    ad505a6 View commit details
    Browse the repository at this point in the history

  4. Don't trigget vjs's fullscreenchange event 

    This event isn't really being used for this usecase right now, so, no
need to trigger it.
    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    cc45177 View commit details
    Browse the repository at this point in the history

  5. Use one for event binding.

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    27e2707 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2014

  1. Listen via 'this.one'. 

    Don't bother checking whether the video element is fullscreen but just
assume we are fullscreen.
    @gkatsev
    gkatsev committed Sep 17, 2014
    Configuration menu
    Copy the full SHA
    1ed3085 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2014

  1. Revert "Don't trigget vjs's fullscreenchange event" 

    This reverts commit cc45177.

Conflicts:
	src/js/media/html5.js
    @gkatsev
    gkatsev committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    0498b10 View commit details
    Browse the repository at this point in the history

  2. No need for if since assume we're in fs

    @gkatsev
    gkatsev committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    f3eccbb View commit details
    Browse the repository at this point in the history

  3. Feature detect old fullscreen instead of UA switch

    @gkatsev
    gkatsev committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    02fe7a4 View commit details
    Browse the repository at this point in the history