Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language methods into externs #1483

Closed
wants to merge 1 commit into from

Conversation

dmlap
Copy link
Member

@dmlap dmlap commented Sep 4, 2014

Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes #1420.

Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes videojs#1420.
@heff
Copy link
Member

heff commented Sep 4, 2014

lgtm. If we want this to go out as a patch it would be easier if this was against stable.

heff added a commit that referenced this pull request Sep 5, 2014
@heff
Copy link
Member

heff commented Sep 5, 2014

Merged and released in 4.8.1

@heff heff closed this Sep 5, 2014
@dmlap dmlap deleted the hotfix/extern-langs branch September 29, 2014 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

languages() should be an extern
2 participants