adding a currentType method to get current source type if known #1320
Conversation
|
Unsetting |
| @@ -1172,6 +1178,10 @@ vjs.Player.prototype.currentSrc = function(){ | |||
| return this.techGet('currentSrc') || this.cache_.src || ''; | |||
| }; | |||
|
|
|||
| vjs.Player.prototype.currentType = function(){ | |||
| return this.srcType_ || ''; | |||
There was a problem hiding this comment.
Use currentType_ instead of srcType_ for the private property. That's how other properties are set up.
|
Great stuff, thanks Matt! Still working on a few more inline comments. |
| @@ -1144,16 +1156,10 @@ vjs.Player.prototype.src = function(source){ | |||
|
|
|||
| if (!this.isReady_) { | |||
There was a problem hiding this comment.
I think this ready check will need to happen before anytime we set source. Could probably move it into setSource?
|
@gkatsev passing no argument results in |
|
Thanks @heff - have pushed some more changes based on your comments. |
| if (this.options_['autoplay']) { | ||
| this.play(); | ||
| } | ||
| }).bind(this); |
There was a problem hiding this comment.
ie8 unfortunately doesn't support bind. There's a vjs.bind method in lib.js though.
|
This is looking good. I'll be able to get it pulled in next week. |
|
Made a PR against this branch here: https://github.com/guardian/video.js/pull/1 |
Guardian source type
Alternative solution for the problem posed in #1313. See that PR for discussion.