Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust subtitle timing by optional offset #1212

Closed
wants to merge 3 commits into from
Closed

Adjust subtitle timing by optional offset #1212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2830c89
adjust subtitle timing by optional offset
these8bits May 14, 2014
f926505
set trackTimeOffset on player_.options()
these8bits May 15, 2014
423a730
add missing semicolon
these8bits May 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/js/tracks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,8 +551,9 @@ vjs.TextTrack.prototype.parseCueTime = function(timeText) {
vjs.TextTrack.prototype.update = function(){
if (this.cues_.length > 0) {

// Get curent player time
var time = this.player_.currentTime();
// Get current player time, adjust for track offset
var offset = this.player_.options()['trackTimeOffset'] || 0;
var time = this.player_.currentTime() + offset;

// Check if the new time is outside the time box created by the the last update.
if (this.prevChange === undefined || time < this.prevChange || this.nextChange <= time) {
Expand Down